Repository navigation
refactor(io): encapsulate storage backend dispatch - #28
Merged
thweetkomputer merged 3 commits intoNov 3, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage operations currently pass through
NetBackend, whileWorkerrepeats the SPDK/io_uring selection for each operation. This change introducesStorageBackendand givesWorkerownership of the single shared kernel ring. The publicWorkersubmission APIs remain unchanged.StorageBackend, backed bySpdkBackendor the shared io_uring backend; remove storage methods fromNetBackend.initialized_flag; callbacks access the embedded backend directly and keep that binding through shutdown draining.Validation (from the Bycorf repository):
The test builds use
CMAKE_BUILD_TYPE=DebugandBYCORF_BUILD_EXAMPLES=OFF; the bypass build additionally usesBYCORF_KERNEL_BYPASS=ON.Both builds and all tests passed: 95 normal tests and 121 bypass-capable tests, including SPDK device-stub shutdown/reentry cases and DPDK software tests. The new shared-ring regression mixes network sends and storage reads and checks that stopping the facades does not destroy the worker-owned ring. Formatting passed. Hardware NIC/NVMe performance was not benchmarked.
GCC 13/AArch64
-O2and-O3assembly probes for read, send, sendmsg, and cancel are instruction-identical to explicit ring-parameter forwarding in both normal and bypass configurations, after normalizing local labels. This is a refactor, not a throughput claim.